Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Make things more Go like #26

Merged
merged 10 commits into from
May 14, 2024
Merged

[refactor] Make things more Go like #26

merged 10 commits into from
May 14, 2024

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented May 14, 2024 •
edited
Loading

  1. Remove snake case usage in a few places
  2. Add proper documentation for many places
  3. Finish breaking down / moving files to where they belong in packages. crypto and bcs are separated, everything else is aptos
  4. Fix misspelling in expiration timestamp

brianolson
brianolson reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this and in some cases it could make the SDK less good for developers.

cmd/goclient/goclient.go Outdated Show resolved Hide resolved
cmd/goclient/goclient.go Outdated Show resolved Hide resolved
brianolson
brianolson reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. This feels right based on my experience of the Go ecosystem. One quibble on a couple _test.go files, otherwise good

resource_test.go Outdated Show resolved Hide resolved
transactions_test.go Outdated Show resolved Hide resolved
@gregnazario gregnazario merged commit 1cb7125 into main May 14, 2024
1 check passed
@gregnazario gregnazario deleted the refactor-more branch May 14, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianolson brianolson brianolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregnazario @brianolson